Skip to main content

Legacy code, improvement task that are not finished

By
Until now I was involved in several projects that contained a lot of legacy code. On each project of this type people tried to improve the code, refactoring it and so on. I think that all of us know this story.
Having a code base with 3 million lines of code or 10 millions lines of code will contain a lot of crape. The code improvement action will never finish, this action will continue until the end of the project (end of maintenance phase) or end of the world.
It is very easily to find problems in a code that was not written by you. In cases like this you can propose a solution. If the architect or the person that is responsible on the project will accept your proposal, sometimes you will have allocated time for this task. We can have one, two, ten or more improvement tasks that run in the same time – assigned to different team members.
But what is happening when an issue is discovered and you receive a phone call from the client with a 911 problem? You will put the improvement task on hold. The same thing can happen when you have a backlog, you start working to the improvement task, but something happens and you have to put the task on hold.
Putting a project on hold is not a problem, but forgetting an improvement task that is partial done can generate an uglier code that you think so. In this case the “forgetting” term don’t refer only to the developer that forgets about the task itself. For example we can have a case when the management will not allocate team anymore for the given task.
In cases like this it is important to look over the changes and decide what you should do with the changes that were already done on the given task. Letting the changes in the code will not be all the time a good approach. You can end up with method, classes or functionality that is not used or with code that do the same thing in two different ways. When a new developer will come on the project and will look over the code he will not know what is happing there - people code and go, we are agile.
Developers will try to improve the code, having 100 great ideas how code can be improved and will start 200 task of code improving in the same time. What is important, when you start a task, you should also finish it. Starting a lot of improvement tasks without finishing them will increase the “legacy” part of the project.
Be prepared to fight for the improvement task. The code should add value to a project (functional/non-functional), it is not only developer fad.

Comments

  1. tudor_turcuAugust 6, 2013 at 6:14 PM

    So true.. Usually a code improvement task should be done on a separate branch, so if it's 'paused' no unfinished work is left over in the main development branch..

    ReplyDelete

Post a Comment

Popular posts from this blog

Windows Docker Containers can make WIN32 API calls, use COM and ASP.NET WebForms

By
After the last post , I received two interesting questions related to Docker and Windows. People were interested if we do Win32 API calls from a Docker container and if there is support for COM. WIN32 Support To test calls to WIN32 API, let’s try to populate SYSTEM_INFO class. [StructLayout(LayoutKind.Sequential)] public struct SYSTEM_INFO { public uint dwOemId; public uint dwPageSize; public uint lpMinimumApplicationAddress; public uint lpMaximumApplicationAddress; public uint dwActiveProcessorMask; public uint dwNumberOfProcessors; public uint dwProcessorType; public uint dwAllocationGranularity; public uint dwProcessorLevel; public uint dwProcessorRevision; } ... [DllImport("kernel32")] static extern void GetSystemInfo(ref SYSTEM_INFO pSI); ... SYSTEM_INFO pSI = new SYSTEM_INFO(
Post a Comment
Read more

Azure AD and AWS Cognito side-by-side

By
In the last few weeks, I was involved in multiple opportunities on Microsoft Azure and Amazon, where we had to analyse AWS Cognito, Azure AD and other solutions that are available on the market. I decided to consolidate in one post all features and differences that I identified for both of them that we should need to take into account. Take into account that Azure AD is an identity and access management services well integrated with Microsoft stack. In comparison, AWS Cognito is just a user sign-up, sign-in and access control and nothing more. The focus is not on the main features, is more on small things that can make a difference when you want to decide where we want to store and manage our users.  This information might be useful in the future when we need to decide where we want to keep and manage our users.  Feature Azure AD (B2C, B2C) AWS Cognito Access token lifetime Default 1h – the value is configurable 1h – cannot be modified
Post a Comment
Read more

ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded

By
Today blog post will be started with the following error when running DB tests on the CI machine: threw exception: System.InvalidOperationException: The Entity Framework provider type 'System.Data.Entity.SqlServer.SqlProviderServices, EntityFramework.SqlServer' registered in the application config file for the ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded. Make sure that the assembly-qualified name is used and that the assembly is available to the running application. See http://go.microsoft.com/fwlink/?LinkId=260882 for more information. at System.Data.Entity.Infrastructure.DependencyResolution.ProviderServicesFactory.GetInstance(String providerTypeName, String providerInvariantName) This error happened only on the Continuous Integration machine. On the devs machines, everything has fine. The classic problem – on my machine it’s working. The CI has the following configuration: TeamCity .NET 4.51 EF 6.0.2 VS2013 It see
8 comments
Read more